Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure host port #139

Merged

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Sep 3, 2023

ECOPROJECT-1581
Currently the hostPort: 30001 is fixed by the operator and is no possible to change, making it impossible for pods to deploy if that port is already in use.
This PR makes the port configurable.

Signed-off-by: Michael Shitrit <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2023
@mshitrit
Copy link
Member Author

mshitrit commented Sep 3, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.11-ci-index-self-node-remediation-bundle
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.11-test
  • /test 4.12-ci-index-self-node-remediation-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-index-self-node-remediation-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-index-self-node-remediation-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

mshitrit commented Sep 3, 2023

/test 4.13-openshift-e2e

@mshitrit
Copy link
Member Author

mshitrit commented Sep 3, 2023

/test 4.12-openshift-e2e

@mshitrit
Copy link
Member Author

mshitrit commented Sep 4, 2023

/override ci/prow/4.13-openshift-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

@mshitrit: Overrode contexts on behalf of mshitrit: ci/prow/4.13-openshift-e2e

In response to this:

/override ci/prow/4.13-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clobrano
Copy link
Contributor

clobrano commented Sep 5, 2023

/lgtm
giving a chance to get more feedback before merging, feel free to un-hold
/hold

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@mshitrit mshitrit marked this pull request as ready for review September 6, 2023 06:08
@openshift-ci openshift-ci bot requested review from beekhof and razo7 September 6, 2023 06:08
@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/test 4.13-openshift-e2e

@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/retest

1 similar comment
@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/retest

@mshitrit
Copy link
Member Author

mshitrit commented Sep 7, 2023

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 6f8d6a5 into medik8s:main Sep 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants