Merge pull request #81 from mshitrit/remove_hostPID

remove hostPID
medik8s · Sep 26, 2023 · eea79f7 · eea79f7
2 parents 2750538 + c50daf4
commit eea79f7
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/bundle/manifests/self-node-remediation.clusterserviceversion.yaml b/bundle/manifests/self-node-remediation.clusterserviceversion.yaml
@@ -434,7 +434,7 @@ spec:
   - email: [email protected]
     name: Medik8s Team
   maturity: alpha
-  minKubeVersion: 1.20.0
+  minKubeVersion: 1.25.0
   provider:
     name: Medik8s
     url: https://www.medik8s.io/

diff --git a/config/manifests/bases/self-node-remediation.clusterserviceversion.yaml b/config/manifests/bases/self-node-remediation.clusterserviceversion.yaml
@@ -119,7 +119,7 @@ spec:
   - email: [email protected]
     name: Medik8s Team
   maturity: alpha
-  minKubeVersion: 1.20.0
+  minKubeVersion: 1.25.0
   provider:
     name: Medik8s
     url: https://www.medik8s.io/

diff --git a/install/self-node-remediation-deamonset.yaml b/install/self-node-remediation-deamonset.yaml
@@ -26,7 +26,6 @@ spec:
             type: Directory
       serviceAccountName: self-node-remediation-controller-manager
       priorityClassName: system-node-critical
-      hostPID: true
       containers:
       - args:
         - --is-manager=false
@@ -72,7 +71,6 @@ spec:
             mountPath: /dev
         securityContext:
           privileged: true
-          hostPID: true
         name: manager
         ports:
         - containerPort: {{.HostPort}}

diff --git a/pkg/reboot/rebooter.go b/pkg/reboot/rebooter.go
@@ -71,7 +71,7 @@ func (r *watchdogRebooter) Reboot() error {
 // softwareReboot performs software reboot by running systemctl reboot
 func (r *watchdogRebooter) softwareReboot() error {
 	r.log.Info("about to try software reboot")
-	// hostPID: true and privileged:true required to run this
+	// privileged:true required to run this
 	rebootCmd := exec.Command("/usr/bin/nsenter", "-m/proc/1/ns/mnt", "/bin/bash", "-c", "echo b > /proc/sysrq-trigger")
 
 	if err := rebootCmd.Run(); err != nil {