Add Explicit Workload Deletion #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test 4.13-openshift-e2e |
clobrano
reviewed
Jul 5, 2023
slintes
requested changes
Jul 5, 2023
mshitrit
reviewed
Jul 6, 2023
razo7
force-pushed
the
workload-deletion
branch
2 times, most recently
from
570e7ba
to
b1574e8
Compare
slintes
reviewed
Jul 9, 2023
|
/test 4.13-openshift-e2e |
slintes
requested changes
Jul 26, 2023
slintes
approved these changes
Jul 27, 2023
clobrano
requested changes
Jul 27, 2023
Explicit/manual workload deletion. Deleting the pods and their volume attachments in order to signal the scheduler that this node's workloads should be rescheduled on a different node
Update unit tests to create two VA and pod which will be deleted by FAR pod
Update e2e tests to create one VA and one pod which will be deleted by FAR pod
|
/lgtm |
clobrano
approved these changes
Jul 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit/Manuel workload deletion.
Deleting the pods and their volume attachments in order to signal the scheduler that this node's workloads should be rescheduled on a different node.
Includes e2e and unit tests which adds volume attachments and pod to the unhealthy node in order to verify if they have deleted as expected.
ECOPROJECT-1473