Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two Remediations and Taint Addition for E2E #62

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Two Remediations and Taint Addition for E2E #62

merged 4 commits into from
Jul 25, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jul 2, 2023

  • Reorganize FAR E2E test code for testing two FAR creation, one following another, to two different nodes.
  • Test the addition of FAR taint prior to checking the pod's logs and the node's boot time

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Jul 2, 2023
@mshitrit
Copy link
Member

mshitrit commented Jul 2, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-index
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.13-ci-index
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.14-ci-index
  • /test 4.14-images
  • /test 4.14-openshift-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member

mshitrit commented Jul 2, 2023

/test 4.13-openshift-e2e

@razo7 razo7 changed the title Two Second Reboot and Taint Addition Two Remediations and Taint Addition for E2E Jul 4, 2023
@razo7
Copy link
Member Author

razo7 commented Jul 4, 2023

/test 4.13-openshift-e2e

@razo7
Test second reoboot for different node
b5837bd 
Stress the cluster with one after another FAR CRs, and watch if they succeed
@razo7
Copy link
Member Author

razo7 commented Jul 9, 2023

/test 4.13-openshift-e2e

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Jul 10, 2023

/test 4.13-openshift-e2e

@clobrano
Copy link
Contributor

Is it expected to have two commits with the same name? (also there's a little typo "reoboot")

clobrano
clobrano reviewed Jul 17, 2023
View reviewed changes
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
slintes
slintes requested changes Jul 17, 2023
View reviewed changes
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/far_e2e_test.go Show resolved Hide resolved
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
@razo7
Test the addition of FAR taint
e265860 
Add wasFarTaintAdded to check if the node has FAR taint prior to checking the pod's logs and the node's boot time
@razo7
Randomize tested worker node
79fe6c1 
We randomize using the current time as seed and we store the old node name so we won't create new CR for the same node on the second test
@razo7
Copy link
Member Author

razo7 commented Jul 19, 2023

/test 4.13-openshift-e2e

slintes
slintes requested changes Jul 24, 2023
View reviewed changes
test/e2e/far_e2e_test.go Outdated Show resolved Hide resolved
@razo7
Use random seed for node selection in E2E
fd36520 
The random number was not been used to select the worker node
@razo7
Copy link
Member Author

razo7 commented Jul 25, 2023

/test 4.13-openshift-e2e

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review July 25, 2023 12:52
@openshift-ci openshift-ci bot requested review from beekhof and mshitrit July 25, 2023 12:52
@openshift-merge-robot openshift-merge-robot merged commit b603f13 into medik8s:main Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano clobrano left review comments

@slintes slintes slintes approved these changes

@beekhof beekhof Awaiting requested review from beekhof

@mshitrit mshitrit Awaiting requested review from mshitrit

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@razo7 @mshitrit @clobrano @slintes @openshift-merge-robot