Exclude the upper bound of range #36283
Open
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:JS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/javascript/reference/global_objects/array/from/index.md
Outdated
Show resolved
Hide resolved
|
Preview URLs (comment last updated: 2024-10-09 13:10:11) |
geryogam
changed the title
geryogam
changed the title
Josh-Cena
reviewed
Oct 9, 2024
| const range = (start, stop, step) => | ||
| Array.from({ length: (stop - start) / step + 1 }, (_, i) => start + i * step); | ||
| Array.from( | ||
| { length: Math.ceil((stop - start) / step - 1) + 1 }, |
There was a problem hiding this comment.
Suggested change
| { length: Math.ceil((stop - start) / step - 1) + 1 }, | |
| { length: Math.ceil((stop - start) / step) }, |
Right? I didn't think too much about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We make the
stopupper bound of therange(start, stop, step)function exclusive in the example given in theArray.from()page.Motivation
The built-in Python and Clojure
range(start, stop, step)functions use the preferred range convention that includes the lower bound and excludes the upper bound (cf. Edsger Dijkstra’s notes Why Numbering Should Start at Zero for the rationale). The built-in PHPrange(start, stop, step)function uses another range convention that includes both the lower bound and upper bound.Additional details
More complete TypeScript implementations of
range(start, stop, step)with therange(stop)overload (the first is not lazy and the second one is lazy).