Version 10

[mmoll]

No description provided.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c44311b) 100.00% compared to head (a7890f8) 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##              master      #207   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       150       150           
===========================================
  Files              8         8           
  Lines            611       669   +58     
===========================================
+ Hits             611       669   +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmoll]

@Khartir @valentin-schaeidt-mayflower could you check the Attributes rules in your respective project and report back if this fits your needs?

[Khartir]

Minor issue: sorting the attributes alphabetically includes a leading \ in the order. This leads to #[\Attribute] always being the last attribute, but that's a negligible edge-case.

More importantly, I just had this happen:

    #[Bar()]
-    // TODO do something
    public function foo(): void

[mmoll]

Thanks, I opened slevomat/coding-standard#1497.

[mmoll]

@Khartir Could you check again? :)

[Khartir]

It still does weird stuff:

 //phpcs:disable SlevomatCodingStandard.PHP.ForbiddenClasses
-#[Bar()] /** foo */
 class TestCase

But I think we can merge this and either fix it upstream or disable offending sniffs downstream.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[xalopp]

Looks good to me.