-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly updates for phantomjs 2.0 by DEfusion #32
Open
jeremyk
wants to merge
8
commits into
maxwell:master
Choose a base branch
from
Eventshare:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−76
Commits on Oct 8, 2015
-
Configuration menu - View commit details
-
Copy full SHA for bcf0adf - Browse repository at this point
Copy the full SHA bcf0adfView commit details -
For some reason it wasn't loading for me and thus the callback was never called. We don't need jQuery to do those calculations anyway so clean it up by removing it.
Configuration menu - View commit details
-
Copy full SHA for d20c1f5 - Browse repository at this point
Copy the full SHA d20c1f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 166358b - Browse repository at this point
Copy the full SHA 166358bView commit details
Commits on Oct 14, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 6b0b881 - Browse repository at this point
Copy the full SHA 6b0b881View commit details
Commits on Feb 23, 2016
-
Jeremy Kallman committed
Feb 23, 2016 Configuration menu - View commit details
-
Copy full SHA for cf5bf50 - Browse repository at this point
Copy the full SHA cf5bf50View commit details -
Fix for div not found when it hasn’t rendered yet.
Happens when div loading is dependent on resources loading.
Jeremy Kallman committedFeb 23, 2016 Configuration menu - View commit details
-
Copy full SHA for 64214bc - Browse repository at this point
Copy the full SHA 64214bcView commit details -
Jeremy Kallman committed
Feb 23, 2016 Configuration menu - View commit details
-
Copy full SHA for 376bb70 - Browse repository at this point
Copy the full SHA 376bb70View commit details
Commits on Apr 1, 2016
-
Fix for not capturing with a height arg correctly.
- Instead of modifying the height of the body (and html) after render we just set the mask to take care of it. The image we were getting was of the full size page cropped down to the height and the rest filled with white. I think this is because the larger initial page size caused the viewport to expand but then it didn’t contract. - Since args.div will supersede the mask eventually, don’t set the mask up front if args.div is present. Set the mask solely on the height arg as we can default top and left to 0. This fixes the failing unit tests when running locally.
Jeremy Kallman committedApr 1, 2016 Configuration menu - View commit details
-
Copy full SHA for 0478476 - Browse repository at this point
Copy the full SHA 0478476View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.