Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system.args if phantom.args is undefined #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathanvda
Copy link

In phantomjs versions > 2.0 phantom.args is
no longer supported, and we should use system.args instead.

When I installed screencap on my dev machine, it just worked, but somehow when deploying on my clients windows server it did not work. I got an error on phantom.args being undefined, and when looking it up, I found it is no longer used in the new versions (>2.0). We should use system.args instead. For me this version works on both my dev machine and windows server.

The code should still work for lower versions as well.

In phantomjs versions > 2.0 phantom.args is
no longer supported, and we should use system.args instead.
@nathanvda
Copy link
Author

From the documentation: http://phantomjs.org/api/phantom/property/args.html

@DEfusion
Copy link
Collaborator

DEfusion commented Feb 1, 2016

Note that this was added also in my open PR #28

@nathanvda
Copy link
Author

Hi @DEfusion indeed, but your branch has not yet been merged, so I assumed the rest of your branch was up for discussion, but this should be merged anyhow, so I imagined a "leaner" branch could get merged sooner.

@nofxx
Copy link
Contributor

nofxx commented Mar 14, 2016

I confirm this works with phantom 2.1.1 on archlinux!

Please merge!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants