Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Validate state when saved display unavailable #45

Merged
merged 9 commits into from
Nov 25, 2018
Merged

Fix: Validate state when saved display unavailable #45

merged 9 commits into from
Nov 25, 2018

Commits on Nov 14, 2018

  1. Update .gitignore and package-lock.json

    @MathieuDebit
    MathieuDebit committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    52b2bfc View commit details
    Browse the repository at this point in the history

  2. Add tests to control window visibility at startup 

    - Ensure window is visible at startup if saved display is unavailable and was on the left or right
    @MathieuDebit
    MathieuDebit committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    aac92c0 View commit details
    Browse the repository at this point in the history

  3. Fix validateState method when saved display is unavailable 

    - Reset state to default values on the retrieved display
- Add tests
    @MathieuDebit
    MathieuDebit committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    daae1b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Revert .gitignore

    @MathieuDebit
    MathieuDebit committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    d51e43b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Add a new failing test 

    - Validate state if saved display is available but window outside display bounds
    @MathieuDebit
    MathieuDebit committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    5507f84 View commit details
    Browse the repository at this point in the history

  2. Add and export resetStateToDefault() method

    @MathieuDebit
    MathieuDebit committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    91146ae View commit details
    Browse the repository at this point in the history

  3. Ensure window is visible on some display during state validation

    @MathieuDebit
    MathieuDebit committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    477f3db View commit details
    Browse the repository at this point in the history

  4. Remove deep-equal dependency

    @MathieuDebit
    MathieuDebit committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    ee6c18c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Remove failing test

    @MathieuDebit
    MathieuDebit committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    2538e1d View commit details
    Browse the repository at this point in the history