1341 Issue fix - reports folder is created (empty) when you specify output flag #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcriado
changed the title
|
Hi Antonio! Thanks for the contribution! Seems a valid fix @shelld3v, right? |
|
This should work, but I'm seeing a very similar check here. I'm wondering whether we should move that piece of code (creating report folder for auto-save reports) to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reports folder is always created where you execute the app even though you specify output flag because controller.setup method is not handling the options["output"] value, so it creates the folder ("reports" name by default, stored in options["output_path"]) leaving it empty.
I just control if options["output"] comes with value as it is done in controller.setup_reports method
Fix #1341