Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(verify-era-proof-attestation): add support for verifying a range of batches #194

Merged
merged 4 commits into from
Sep 3, 2024
Merged

feat(verify-era-proof-attestation): add support for verifying a range of batches #194

merged 4 commits into from
Sep 3, 2024

Conversation

pbeza
Copy link
Contributor

@pbeza pbeza commented Sep 2, 2024

No description provided.

@pbeza
Copy link
Contributor Author

pbeza commented Sep 2, 2024

Howto:

$ docker run -i --rm $IMAGE_TAG --batch-number 598706-598709 --rpc-url https://z2-dev-api.zksync.dev                                                                                                                  
Verifying batch #598706 proved at 2024-08-20T10:39:37.599647Z
Verifying quote (4730 bytes)...
        Info: Advisory ID: INTEL-SA-00615
Quote verification result: SwHardeningNeeded: Software hardening is needed
mrsigner: c5591a72b8b86e0d8814d6e8750e3efe66aea2d102b8ba2405365559b858697d
mrenclave: 3bf2464401ff6055922718d1d1496ad2c34a11590bc5b8a83ad2d7b31902148c
reportdata: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b4745857900000000000000000000000000000000000000000000000000000000000000
Public key from attestation quote: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b47458579
Root hash: 0xcc1e…2459
Signature verified successfully

Verifying batch #598707 proved at 2024-08-20T10:40:33.942582Z
Verifying quote (4730 bytes)...
        Info: Advisory ID: INTEL-SA-00615
Quote verification result: SwHardeningNeeded: Software hardening is needed
mrsigner: c5591a72b8b86e0d8814d6e8750e3efe66aea2d102b8ba2405365559b858697d
mrenclave: 3bf2464401ff6055922718d1d1496ad2c34a11590bc5b8a83ad2d7b31902148c
reportdata: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b4745857900000000000000000000000000000000000000000000000000000000000000
Public key from attestation quote: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b47458579
Root hash: 0x6cfa…b3a1
Signature verified successfully

Verifying batch #598708 proved at 2024-08-20T10:41:30.060710Z
Verifying quote (4730 bytes)...
        Info: Advisory ID: INTEL-SA-00615
Quote verification result: SwHardeningNeeded: Software hardening is needed
mrsigner: c5591a72b8b86e0d8814d6e8750e3efe66aea2d102b8ba2405365559b858697d
mrenclave: 3bf2464401ff6055922718d1d1496ad2c34a11590bc5b8a83ad2d7b31902148c
reportdata: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b4745857900000000000000000000000000000000000000000000000000000000000000
Public key from attestation quote: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b47458579
Root hash: 0x7e97…3b2d
Signature verified successfully

Verifying batch #598709 proved at 2024-08-20T10:42:26.461951Z
Verifying quote (4730 bytes)...
        Info: Advisory ID: INTEL-SA-00615
Quote verification result: SwHardeningNeeded: Software hardening is needed
mrsigner: c5591a72b8b86e0d8814d6e8750e3efe66aea2d102b8ba2405365559b858697d
mrenclave: 3bf2464401ff6055922718d1d1496ad2c34a11590bc5b8a83ad2d7b31902148c
reportdata: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b4745857900000000000000000000000000000000000000000000000000000000000000
Public key from attestation quote: 02fc48a5b6ad67df2ddeeffcd3a929f3be2997cac8d9d0599b0ec34d0b47458579
Root hash: 0xfede…7c71
Signature verified successfully

@pbeza pbeza marked this pull request as ready for review September 2, 2024 14:15
@pbeza pbeza requested a review from a team as a code owner September 2, 2024 14:15
@pbeza pbeza changed the title feat(verify-era-proof-attestation): add range of batches verification feat(verify-era-proof-attestation): add support for verifying a range of batches Sep 2, 2024
@haraldh
Copy link
Contributor

haraldh commented Sep 3, 2024

Do we need some rate limiting?

@pbeza
Copy link
Contributor Author

pbeza commented Sep 3, 2024

Do we need some rate limiting?

Yeah, why not? It doesn’t hurt to add a feature that can be turned off by default (unless you prefer to enable it by default).

@pbeza pbeza force-pushed the patrick/verify-range-of-batches branch from 1ff076e to a5871e0 Compare September 3, 2024 12:18
@haraldh haraldh enabled auto-merge (squash) September 3, 2024 12:26
@haraldh haraldh merged commit 0e6eb2b into main Sep 3, 2024
6 checks passed
@haraldh haraldh deleted the patrick/verify-range-of-batches branch September 3, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraldh haraldh haraldh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbeza @haraldh