-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(verify-attestation): RPC attestation and batch signature verification binary #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbeza
force-pushed
the
patrick/sgx-rpc-attestation-verifier
branch
11 times, most recently
from
August 14, 2024 15:24
b35014a
to
bc42e30
Compare
small bike shedding.... rename |
Also we want to create the docker container with the github actions, so please add it to the CI |
haraldh
requested changes
Aug 29, 2024
To use verify-rpc-attestation, run:
|
btw:
can also be:
|
you might wanna rebase and squash the commits |
haraldh
force-pushed
the
patrick/sgx-rpc-attestation-verifier
branch
from
August 29, 2024 10:33
3e5aa43
to
f322fc7
Compare
done |
…ation binary This is another variant of the binary tool for verifying attestation and the signature of a given batch. Unlike the existing tool, this variant does not require you to provide two separate files—one for the attestation and one for the signature. Instead, it automatically fetches both from the RPC node. Unfortunately, after discussing with @popzxc, we found that there is no way to reuse the RPC client because our published crates on crates.io are outdated and do not include the recently merged TEE-specific code changes. To be fixed in the future.
pbeza
force-pushed
the
patrick/sgx-rpc-attestation-verifier
branch
from
August 30, 2024 10:15
d84182c
to
5e4b890
Compare
haraldh
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another variant of the binary tool for verifying attestation and the signature of a given batch. Unlike the existing tool, this variant does not require you to provide two separate files – one for the attestation and one for the signature. Instead, it automatically fetches both from the RPC node.
Unfortunately, after discussing with @popzxc, we found that there is no way to reuse the RPC client because our published crates on crates.io are outdated and do not include the recently merged TEE-specific code changes. To be fixed in the future.
To use
verify-rpc-attestation
, run: