feat: merge the manifest attribute sets better #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbeza
reviewed
Jun 6, 2024
pbeza
previously approved these changes
Jun 6, 2024
haraldh
force-pushed
the
recursiveMerge
branch
2 times, most recently
from
96e3064
to
66d541d
Compare
* merge the arrays `fs.mounts` and `sgx.trusted_files` instead of replacing them. * append `loader.env.LD_LIBRARY_PATH` instead of replacing it. Signed-off-by: Harald Hoyer <[email protected]>
pbeza
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.mountsandsgx.trusted_filesinstead of replacing them.loader.env.LD_LIBRARY_PATHinstead of replacing it.