Finished public and core API #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluk64
requested changes
Jul 31, 2019
gluk64
requested changes
Aug 1, 2019
| contract EllipticCurve { | ||
|
|
||
| // Current curve parameters | ||
| CommonTypes.CurveParams private curveParams; |
There was a problem hiding this comment.
там bytes, я честно говоря даже не знаю как они сохраняются. надо померять газ.
contracts/GenericEllipticCurve.sol
Outdated
| // Compies the common prefix for pairing operation based on curve parameters. | ||
| // Returns the newly created bytes memory. | ||
| function getPairingOpDataInBytes(CommonTypes.CurveParams memory curveParams) private pure returns (bytes memory) { | ||
| bytes memory opData = new bytes(6 + 6 * curveParams.fieldLength + curveParams.groupOrderLength + curveParams.xLength); |
There was a problem hiding this comment.
я не понимаю, где оптимизация кода ниже? давай созвонимся
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.