Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: setInsistingOnDeprecatedConfigVersion to "false" #3484

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kt86
Copy link
Contributor

@kt86 kt86 commented Sep 16, 2024

, when creating a new Config or reading in a Config in the current version (v2).

This avoids the misleading error in VSPConsitencyCheck, where it suggests, that we have an old version, but it is only created in Code.

On the midterm, the default in GlobalConfigGroup should be changed, and the "true" should be assigned when reading in an old version.

… config or reading in a config in the current version.
…h configs, that are read by the V2 reader, but the ScoringConfigGroup detects a deprecated syntax...
@kt86
Copy link
Contributor Author

kt86 commented Sep 16, 2024

grafik
Some contribs have Issues, when setting this here on Reading a Config V2. -> Seems to be some mixture of file format and scoring parameters,...
-> Deactivate it again in the ConfigReader and only solve the Issue for creating a new Config in code.

@kt86 kt86 marked this pull request as ready for review September 16, 2024 11:24
@kt86 kt86 requested review from rakow and removed request for rakow September 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant