Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for authenticated SMTP with a custom port #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

awesome-michael
Copy link

Sending emails fails if the port is used in smtp.PlainAuth. Since no timeout is configured this error blocks the complete application.
I separated host and port of the SMTP server in the config to prevent this.

@richvdh richvdh self-requested a review December 6, 2021 21:39
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

changelog.d/38.misc Outdated Show resolved Hide resolved
submit.go Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelkaye michaelkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok by me, would suggest this change to the changelog as we explicitly mention that it's authentication where there are issues with the current code.

changelog.d/38.bugfix Outdated Show resolved Hide resolved
@michaelkaye michaelkaye requested a review from richvdh April 5, 2022 08:57
@richvdh richvdh changed the title Fix email support Fix support for authenticated SMTP with a custom port Apr 5, 2022
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh
Copy link
Member

richvdh commented Apr 5, 2022

@awesome-michael please could you add a "signed-off-by" to this PR, per https://github.com/matrix-org/rageshake/blob/master/CONTRIBUTING.rst#sign-off?

Signed-off-by: Michael Albert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants