Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geth Merge v1.12.2 #968

Merged
merged 320 commits into from
Nov 10, 2023
Merged

Geth Merge v1.12.2 #968

merged 320 commits into from
Nov 10, 2023

Conversation

temaniarpit27
Copy link
Contributor

@temaniarpit27 temaniarpit27 commented Aug 18, 2023

No description provided.

holiman and others added 30 commits May 23, 2023 06:23
implements the ability to run several state-tests in one instance. By not providing a statetest path to the `evm statetest` command, the path(s) will instead be read from `stdin`.
ethclient accepts certain negative block number values as specifiers for the "pending",
"safe" and "finalized" block. In case of "pending", the value accepted by ethclient (-1)
did not match rpc.PendingBlockNumber (-2).

This wasn't really a problem, but other values accepted by ethclient did match the
definitions in package rpc, and it's weird to have this one special case where they don't.

To fix it, we decided to change the values of the constants rather than changing ethclient.
The constant values are not otherwise significant. This is a breaking API change, but we
believe not a dangerous one.

---------

Co-authored-by: Felix Lange <[email protected]>
* internal: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* tests: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* tests: go autoimport

Signed-off-by: jsvisa <[email protected]>

* tests: go autoimport

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
* eth: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* consensus: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
* core: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* console: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* core: go autoimport

Signed-off-by: jsvisa <[email protected]>

* core: dry

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
* accounts: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* accounts: go autoimport

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
This change implements async log retrievals via feeding logs in channels, instead of returning slices. This is a first step to implement #15063.  

---------

Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
RPC methods `eth_getHeaderBy*` returned a size value which was meant for internal
processes. Please instead use `size` field returned by `eth_getBlockBy*` if you're interested
in the RLP encoded storage size of the block.

Signed-off-by: jsvisa <[email protected]>
This change splits up the multiple API functions / namespaces currently defined in the eth package into different per-namespace files.
eth: make StorageRangeAt take a block hash or number

Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
This is a minor optimization/refactoring of Feed.

---------

Co-authored-by: Felix Lange <[email protected]>
…mplementation (#27310)

Deserialize hex keys early to shortcut on invalid input, and re-use the account storageTrie for each proof for each proof in the account, preventing repeated deep-copying of the trie.

Closes #27308

 --------

Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Drop the notions of uncles, and disables activities while syncing

-  Disable activities (e.g. generate pending state) while node is syncing,
-  Disable empty block submission (but empty block is still kept for payload building),
-  Drop uncle notion since (ethash is already deprecated)
* p2p/discover: remove ReadRandomNodes

Even though it's public, this method is not callable by code outside of
package p2p/discover because one can't get a valid instance of Table.

* p2p/discover: add Table.Nodes

* p2p/discover: make Table settings configurable

In unit tests and externally developed cmd/devp2p test runs, it can be
useful to tune the timer intervals used by Table.
Continuing with a series of PRs to make the Trie interface more generic, this PR moves
the RLP encoding of storage slots inside the StateTrie and light.Trie implementations,
as other types of tries don't use RLP.
@temaniarpit27 temaniarpit27 changed the title merge geth v1.12.2 Geth Merge v1.12.2 Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 493 lines in your changes are missing coverage. Please review.

Files Coverage Δ
accounts/abi/abi.go 82.73% <100.00%> (+0.63%) ⬆️
accounts/abi/error.go 73.80% <100.00%> (+11.90%) ⬆️
accounts/abi/reflect.go 89.93% <100.00%> (ø)
accounts/abi/topics.go 95.83% <100.00%> (ø)
accounts/keystore/account_cache.go 89.16% <100.00%> (-0.11%) ⬇️
common/math/big.go 69.59% <ø> (ø)
consensus/clique/api.go 0.00% <ø> (ø)
consensus/clique/snapshot.go 78.15% <100.00%> (-0.42%) ⬇️
core/blockstm/mvhashmap.go 77.84% <ø> (-0.14%) ⬇️
core/bor_blockchain.go 40.00% <ø> (ø)
... and 93 more

... and 235 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@temaniarpit27 temaniarpit27 merged commit 384383c into develop Nov 10, 2023
12 checks passed
@temaniarpit27 temaniarpit27 deleted the arpit/pos-1731 branch November 10, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.