Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search api #1050

Closed
wants to merge 5 commits into from
Closed

add search api #1050

wants to merge 5 commits into from

Conversation

kislogic
Copy link

@kislogic kislogic commented Oct 17, 2023

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@pratikspatil024
Copy link
Member

Hi @kislogic, thanks for the PR, please update the description.

@marcello33
Copy link
Contributor

Hey @kislogic please fix CI lint and unit-tests

@manav2401
Copy link
Contributor

Hey @kislogic, any updates on this? Please update the description and failing tests before our team reviews this. Thanks!

@0xKrishna
Copy link
Contributor

@kislogic Please provide some context and desc for the team to review this, Also some test cases would be a good plus.

@temaniarpit27
Copy link
Contributor

temaniarpit27 commented Nov 30, 2023

@kislogic Please raise the PR against develop branch and not on master
Also, please check the comments of the developers so that we can go ahead and review the PR

@temaniarpit27
Copy link
Contributor

Closing this for now. Please feel free to reopen when above comments are resolved. We will take a look at this
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants