스케줄 장소 포함 기능 #299
Merged
스케줄 장소 포함 기능 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for affectionate-jones-aa31c6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kikiyeom
force-pushed
the
feature/add-location
branch
from
d254ea4
to
b788281
Compare
sanoopark
approved these changes
Mar 5, 2024
| longitude: roadAddress.x, | ||
| placeName: roadAddress.building_name ?? roadAddress.address_name, | ||
| }); | ||
| setValue('placeName', roadAddress.building_name); |
There was a problem hiding this comment.
앱에 building_name과 지도 핀만 노출하는 것이 기획이죠?
building_name이 ""인 경우는 어드민 장소 인풋에 입력되는 값이 없어서, 성공 여부를 알려줄 디자인이 있으면 좋을 것 같긴 합니다만.. 급하다면 패스해도 좋습니다
{
"address_name": "경기 성남시 분당구 서판교로 32",
"building_name": "",
"main_building_no": "32",
"region_1depth_name": "경기",
"region_2depth_name": "성남시 분당구",
"region_3depth_name": "판교동",
"road_name": "서판교로",
"sub_building_no": "",
"underground_yn": "N",
"x": "127.097880906475",
"y": "37.389777093851",
"zone_no": "13479"
}| @@ -40,6 +40,7 @@ | |||
| /> | |||
| <meta property="og:image" content="/assets/og-image.png" /> | |||
| <link rel="icon" href="/assets/favicon.svg" /> | |||
| <script src="//t1.daumcdn.net/mapjsapi/bundle/postcode/prod/postcode.v2.js"></script> | |||
There was a problem hiding this comment.
https://stackoverflow.com/a/60964007
해당 페이지에서 useScript와 같은 훅을 통해 동적 스크립트 및 async로 불러오는 게 어떨까요?
스크립트 사이즈가 얼마 안 되긴 하지만 스케줄 생성 페이지에서 한정적으로 사용되는 것으로 보여서요!
kikiyeom
force-pushed
the
feature/add-location
branch
from
af8b09f
to
b788281
Compare
|
집 노트북 세팅이 온전치 못해서 리뷰해준 부분은 우선 현재 상태로 dev 배포하고 따로 추가 pr 만들게요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
작업 유형
체크리스트