✨ NEW: Allow for selection of python version #52
Conversation
There was a problem hiding this comment.
thanks @chrisjsewell
it's definitely useful to separate out the creation of the python environment.
since it is directly imported in this role, with specific settings passed to the python role, I guess one then needs to be a bit careful in specifying the same settings when another role wants to reuse the same environment.
in any case, this looks good to me, just minor comments
| python_version: ["3.7"] | ||
| include: | ||
| - distro: "centos8" | ||
| python_version: "3.8" |
There was a problem hiding this comment.
would you mind adding a comment here on why this differentiation is necessary
(e.g. why not all on 3.7/3.8?)
There was a problem hiding this comment.
added 👍
yeh its weird that python37 is not available on CentOS 8 yum, and the other annoyance is: marvel-nccr/ansible-role-python#7
but I didn't want to dwell on these, as really for QM we are only interested in Ubuntu.
chrisjsewell
force-pushed
the
set-python
branch
from
d428ae8
to
ef1c5b5
Compare
Generalise installation of plugins and their code, removing plugin specific tasks. We also install plugins packages at the same time as aiida-core, with the pip 2020-resolver against a single requirements.txt, to ensure the creation of a consistent python environment.
chrisjsewell
force-pushed
the
set-python
branch
from
33a32ab
to
372206c
Compare
venv creation moved to https://github.com/marvel-nccr/ansible-role-python