-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#355 by aquiring exlusive transation lock #356
base: next
Are you sure you want to change the base?
Conversation
It is a bit more complex than that. Most important part here is https://learn.microsoft.com/en-us/windows/win32/api/winscard/nf-winscard-scardbegintransaction#remarks I'd say that you need to make sure that you have exclusive access (no other apps) yourself as well. |
I'm not entirely sure what you mean? Are you saying that we need to employ some special tricks to take account on the possibility that there would be longer pauses between operations than 5s? What could cause such a long pause in between operations within an interaction? Did we used to do that? Now, ofc making sure other apps don't mess up with access is something that probably usually makes sense too and I'm looking into that as well, but why wouldn't we want to grab a lock and prevent anyone else from messing up with the interaction (like we used to) post 6347f0f? |
After some heavy debugging, I think the issue is that for some reason:
..instantly when I insert a card on the reader the pcscd debug log fills with this kind of interaction (and this would just go on for like forever). Like what is this?! 😵
However, after I removed those ACS specific drivers forcing |
But regardless.. I'm not seeing any reason not to wrap inteactions in a transation as suggested in this commit and like it is with the current latest stable release of GPP. If there is some cases where this could be disadvantageous, then perhaps allowing to configure that via cmd line options would make sense. If you prefere that, I can try and enhance this PR to work so that the cli takes |
...as was done until commit 6347f0f removed this behaviour
...as was done until commit 6347f0f removed this behaviour