Account for cpp-options and ghc-options
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
force-pushed
the
account-for-cpp-gcc-flags
branch
from
68d1aca
to
38b8128
Compare
martijnbastiaan
force-pushed
the
account-for-cpp-gcc-flags
branch
2 times, most recently
from
621d871
to
f118cb8
Compare
martijnbastiaan
force-pushed
the
account-for-cpp-gcc-flags
branch
from
f118cb8
to
dffe636
Compare
martijnbastiaan
added a commit
that referenced
this pull request
Aug 3, 2023
This reverts commit b793f25. This breaks a lot of existing code - while it makes sense to use all CPP/GHC args for _parsing_, for evaluating code it depends entirely on the use case. And to invoke the Python Zen: In the face of ambiguity, refuse the temptation to guess.
martijnbastiaan
added a commit
that referenced
this pull request
Aug 3, 2023
This reverts commit b793f25. This breaks a lot of existing code - while it makes sense to use all CPP/GHC args for _parsing_, for evaluating code it depends entirely on the use case. And to invoke the Python Zen: In the face of ambiguity, refuse the temptation to guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71