Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement equality on DimensionValue #23

Conversation

freemansoft
Copy link
Collaborator

@freemansoft freemansoft commented Feb 26, 2024

DimensionValues are equal if their values are equal

Comparing doubles can be bad in some languages because of precision but precision errors results in less equality so I didnt' worry about it.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (b20e952) to head (6af0604).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   98.46%   98.48%   +0.01%     
==========================================
  Files          31       31              
  Lines         847      856       +9     
==========================================
+ Hits          834      843       +9     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikstonge
Copy link
Collaborator

@freemansoft the owner of the repository doesn't seem really active. Should we start our own package?

@mark-nicepants
Copy link
Owner

I can add you as a member to this repo if you want :-) Dont have alot of time currently to pick it up

@frederikstonge
Copy link
Collaborator

I can add you as a member to this repo if you want :-) Dont have alot of time currently to pick it up

If you could add @freemansoft, he's the one who contributes the most!

@mark-nicepants
Copy link
Owner

Added both :-D

@mark-nicepants
Copy link
Owner

I can also add you guys to the pub.dev package later on. For now just ping me when you need a new version published and ill pull and run the script :-) All help is really appreciated 💯

@frederikstonge frederikstonge merged commit b909947 into mark-nicepants:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants