Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COSMIC category to appstream metainfo #3

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jackpot51
Copy link
Contributor

This will allow it to show up in a COSMIC-specific page in the COSMIC store. pop-os/cosmic-store#167

@mariinkys mariinkys merged commit 6308524 into mariinkys:main Sep 27, 2024
@mariinkys
Copy link
Owner

Perfect, thank you!

@bbhtt
Copy link

bbhtt commented Sep 28, 2024

Appstream hasn't updated its category list, so having this now will make it fail validation.

Also it filters all DE names as low quality categories. When the category list in appstream is updated, you have to ask the appstream maintainer to not filter it if you want it in the appstream catalogue data.

See https://github.com/ximion/appstream/blob/3203d61a6bdd248ae4045e13f00cf0951786151c/src/as-utils.c#L1337

@jackpot51
Copy link
Contributor Author

I don't see that mattering for the use case since cosmic-store does its own appstream parsing.

@bbhtt
Copy link

bbhtt commented Sep 28, 2024

Are you parsing the metainfo files directly or the composed catalogue data?

If it's the latter, and the COSMIC category is filtered by appstream even if you have it in metainfo it will not be present in the catalogue data.

@jackpot51
Copy link
Contributor Author

Parsing the composed metainfo. I will request it is not filtered out.

ximion/appstream#669

@jackpot51
Copy link
Contributor Author

@mariinkys I will consult more with @ximion, but for now I'd recommend to remove the COSMIC category and set project_group to COSMIC instead.

@jackpot51
Copy link
Contributor Author

jackpot51 commented Sep 28, 2024

We are comsidering the following, verbatim, for identifying apps made for COSMIC, as discussed on the Pop Chat https://chat.pop-os.org/pop-os/pl/izo1y3d9rtrttyryji7yfnxyoh

For an app:

<provides>
    <id>com.system76.CosmicApplication</id>
</provides>

For an applet:

<provides>
    <id>com.system76.CosmicApplet</id>
</provides>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants