Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disposeProps clearing all props even if predicate is provided #159

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix disposeProps clearing all props even if predicate is provided #159

merged 1 commit into from
May 13, 2024

Conversation

kuhnroyal
Copy link
Contributor

@marcglasberg marcglasberg merged commit 222176e into marcglasberg:master May 13, 2024
1 check failed
@marcglasberg
Copy link
Owner

@kuhnroyal I've improved the tests, and published version 23.0.1

@kuhnroyal kuhnroyal deleted the fix/158-disposeProps branch June 24, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcglasberg marcglasberg marcglasberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disposeProps with predicate incorrectly removes props
2 participants
@kuhnroyal @marcglasberg