Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stylesheets #465

Merged
merged 18 commits into from
Oct 3, 2017
Merged

Update Stylesheets #465

merged 18 commits into from
Oct 3, 2017

Conversation

sarahsnow1
Copy link
Member

@sarahsnow1 sarahsnow1 commented Oct 2, 2017

Overview

Migrates all house styles to latest themed releases, upgrades Tangram, and expands style switcher sample to allow easily testing themes

Proposed Changes

  • Upgrades to Tangram 0.8.1
  • Upgrades stylesheets: bubble wrap 8.0.0, cinnabar 8.0.0, walkabout 6.0.0 refill 9.0.0
  • Migrates all styles to extend ThemedMapStyle
  • Deprecates ZincStyle (will be removed in a future release Remove Deprecated Classes/Methods #466)
  • Updates submodules task to point to updated stylesheet path
  • Adds constants to represent theme type not supported (ie no colors or lod supported)
  • Updates "Switch Style" example to allow selecting lod, label level, and color for each style
  • Expands test coverage

Closes #461

Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove/update the debug log.

}

importBuilder.append(" ] }");
Log.d("sarah", "IMPORT STR: " + importBuilder.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello sarah :D

I guess put for debugging purposes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Removed

}

@Override public int getLabelCount() {
return 12;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this 11 or 12?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its zero indexed and there are 12 label levels for bubble wrap: https://mapzen.com/documentation/cartography/themes/#bubble-wrap

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :D

@sarahsnow1 sarahsnow1 merged commit aeddc24 into master Oct 3, 2017
@sarahsnow1 sarahsnow1 deleted the 461-update-stylesheets branch October 3, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants