Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt justfiles for Docker Compose command #1153

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

justb4
Copy link
Contributor

@justb4 justb4 commented Jan 25, 2024

This should solve #1149. See also my comment there for the approach. In short through a variable that is substituted. Note that this may not work if an older Docker version is installed without the Python docker-compose script...As both variants will not be present. Maybe add an extra test+warning msg for that case.

dockercompose := `if docker-compose --version &> /dev/null; then echo "docker-compose"; else echo "docker compose"; fi`
.
.
up:
   {{ dockercompose }} up

up-build:
    {{ dockercompose }} up --build
.
.

@sharkAndshark sharkAndshark changed the title maplibre/martin#1149 - adapt justfiles for Docker Compose command Adapt justfiles for Docker Compose command Jan 29, 2024
@sharkAndshark
Copy link
Collaborator

Thx @justb4 It works! Now I can run recipes without docker-compose standalone.

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@nyurik nyurik merged commit a864b99 into maplibre:main Jan 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants