Update dependencies: Common SDK to 23.6.0, Maps 10.14.0, NN to 137.0.0 #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kried
commented
Jun 19, 2023
| @@ -67,7 +67,7 @@ class NativeHandlersFactoryTests: TestCase { | |||
| "features": [ | |||
| "custom_feature_key": "custom_feature_value", | |||
| "useInternalReroute": true | |||
| ] | |||
| ] as [String : Any] | |||
There was a problem hiding this comment.
Fixes warnings in the tests
| @@ -402,6 +404,8 @@ public class MapboxRoutingProvider: RoutingProvider { | |||
| routeIndex: routeIndex, | |||
| legIndex: startLegIndex, | |||
| routingProfile: routeOptions.profileIdentifier.nativeProfile, | |||
| baseURL: credentials.host.absoluteString, | |||
| token: credentials.accessToken ?? "", | |||
There was a problem hiding this comment.
Empty token string fallbacks to the previous NN implementation.
Udumft
approved these changes
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #4483 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 189 189
Lines 21190 21190
=======================================
Hits 12358 12358
Misses 8832 8832 |
azarovalex
approved these changes
Jun 19, 2023
Udumft
pushed a commit
that referenced
this pull request
Jun 22, 2023
….0 (#4483) * [Snapshot] Update dependencies: Common SDK to 23.6.0, Maps 10.14.0, NN to 137.0.0 # Conflicts: # Tests/CocoaPodsTest/PodInstall/Podfile.lock
Merged
Udumft
added a commit
that referenced
this pull request
Jun 22, 2023
….0 (#4483) (#4485) * [Snapshot] Update dependencies: Common SDK to 23.6.0, Maps 10.14.0, NN to 137.0. Co-authored-by: Nastassia Makaranka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports the NN v137.0.0 API changes for snapshot build