Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anywidget): Hoist static assets (_esm, _css) to share among front-end widget instances #628

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manzt
Copy link
Owner

@manzt manzt commented Jul 24, 2024

Towards #613

This PR is brings up some challenges for the ecosystem as a whole. I'm very tempted to go forward with #579. That would allow us to avoid the complexity of needing to work with ipywidgets (handling the comm ourself and messages), but currently all the ipywidgets container classes (e.g., Box, HBox, VBox) do an instanceof(widget, ipywidget.Widget) check. That means if we were to introduce a more minimal base class for anywidget.AnyWidget, they couldn't be used in those containers.

Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: 3d9e9e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manzt manzt changed the title feat: Hoist static assets (_esm, _css) to share amoung front-end widget instances feat(anywidget): Hoist static assets (_esm, _css) to share amoung front-end widget instances Jul 24, 2024
@manzt manzt changed the title feat(anywidget): Hoist static assets (_esm, _css) to share amoung front-end widget instances feat(anywidget): Hoist static assets (_esm, _css) to share among front-end widget instances Jul 24, 2024
@manzt manzt marked this pull request as draft July 24, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant