Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image via GitHub Actions #426

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented May 29, 2021

Very preliminary proof of concept. The idea is to have CI create a Docker image for the environment. This would have two potential benefits:

  1. improve build times for subsequent builds that do not modify the environment
  2. make the CI environment available for local usage, allowing users to return to any past environment

@AppVeyorBot
Copy link

AppVeyor build 1.0.238 for commit 205a073 is now complete.

Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.239 for commit df9ac42 is now complete.

Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.240 for commit 1eb3194 is now complete.

Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

@dhimmel dhimmel force-pushed the docker branch 3 times, most recently from 11e6ccd to 1e3e280 Compare May 30, 2021 00:25
[skip_ci]
@agitter
Copy link
Member

agitter commented May 30, 2021

Great idea. Both of those benefits sound good to me and should be achievable.

How much of the CI environment will eventually be added into the Docker image? Initially it has the conda environment. Will spellcheck, PDF generation, or anything else be added later? In particular, I see that the current version uses weasyprint. I don't know much about running Docker (for athenapdf) inside Docker but presume that isn't recommended.

If you don't want to use the older style of conda activation (add to PATH and source activate), we have used the template from this blog post in other projects. It sets the ENTRYPOINT to use conda run to run commands inside the desired environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants