-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save ComicInfo.xml in CBZ Files (Optional) #6102
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dda6cf5
Add ComicInfo.xml generator and include it in chapters file
apiweb f42cfe9
The label has been updated to provide clarity for the user
apiweb 6b04750
Merge branch 'manga-download:master' into comicInfo
apiweb 0ecd47b
Fix code issues
apiweb c46954c
Remove wrong code
apiweb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
export default class ComicInfoGenerator { | ||
apiweb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
createComicInfoXML(series, title, pagesCount) { | ||
series = this.escapeXML(series); | ||
title = this.escapeXML(title); | ||
return `<?xml version="1.0" encoding="utf-8"?> | ||
<ComicInfo xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
<Title>${title}</Title> | ||
<Series>${series}</Series> | ||
<PageCount>${pagesCount}</PageCount> | ||
</ComicInfo>`; | ||
} | ||
|
||
escapeXML(str) { | ||
const symbols = { | ||
'<': '<', | ||
'>': '>', | ||
'&': '&', | ||
'\'': ''', | ||
'"': '"' | ||
}; | ||
|
||
return str.replace(/[<>&'"]/g, function (c) { | ||
return symbols[c]; | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -420,4 +420,4 @@ export default class Settings extends EventTarget { | |
return value; | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instance seems not to be of global significance to be placed in the engine scope, just inject it into the
Storage
constructor, thats the only place where it is really needed.