Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 10 NCSI response #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaelmuller
Copy link

On Windows 10, the Network Connectivity Status Indicator is based on a request made to the following URL: http://www.msftconnecttest.com/connecttest.txt

This PR adds a valid response so that Windows 10 systems are considered connected to the Internet when using fakenet-ng.

@strictlymike
Copy link
Collaborator

strictlymike commented Nov 14, 2019

Thank you for this contribution!

It seems reasonable to expect that this new file used by Windows 10 systems won't break FakeNet for Windows 7 or for Linux, so I'm open to fast-tracking this change without full regression testing.

In your branch, can you please bump up the minor version number in the three files referenced in our documentation for Developing for FakeNet-NG?

(Please also add a comment to the changelog similar to the ones already there, briefly describing the reason for the version change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants