Add 7zip.plugin.asar.vm #1141
Open
Add 7zip.plugin.asar.vm #1141
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d35ha
force-pushed
the
7z-Asar-Plugin
branch
4 times, most recently
from
74295e2
to
1a63e9b
Compare
Ana06
reviewed
Sep 30, 2024
| $pluginsDir = Join-Path ${Env:ProgramFiles} "7-Zip\Formats" | ||
| New-Item -ItemType Directory -Force -Path $pluginsDir | Out-Null | ||
|
|
||
| $zipUrl = "https://www.tc4shell.com/binary/Asar.zip" |
There was a problem hiding this comment.
this URL does not contain a version and will break with updates.
There was a problem hiding this comment.
No versioned URL is available 🥲
There was a problem hiding this comment.
what about install asar using VM-Install-Node-Tool instead of the 7zip plugin? Without a versioned URL, this package will eventually break with a tool update. You should be able to create the package using automation (as I did in #1048) by reviewing #1112, add the send PR label to it, and test the created PR label. Alternatively, you can create the PR manually as you did in #1140, but using the automation would be a good opportunity to get familiar with it 😉
Ana06
added
🆕 package
|
Remember to add labels when creatings PRs 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1112.