Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager): limit the max number of safenode log files #2193

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(manager): limit the max number of safenode log files #2193

merged 1 commit into from
Oct 4, 2024
+814 −24

Conversation

RolandSherwin
Copy link
Member

Adds --max-archived-log-files and --max-log-files to safenode manager.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 4, 2024
View reviewed changes
sn_node_manager/src/add_services/tests.rs
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:8081"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling.

Do not leave debug code in production
sn_node_manager/src/add_services/tests.rs
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:8081"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling.

Do not leave debug code in production
sn_node_manager/src/lib.rs
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:8081"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling.

Do not leave debug code in production
sn_node_manager/src/lib.rs
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:8081"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling.

Do not leave debug code in production
@RolandSherwin RolandSherwin force-pushed the max_logs branch 2 times, most recently from e0a5f17 to 201a14b Compare October 4, 2024 12:22
@RolandSherwin RolandSherwin changed the base branch from main to rc-2024.10.2 October 4, 2024 17:36
@RolandSherwin RolandSherwin changed the base branch from rc-2024.10.2 to stable October 4, 2024 17:37
@RolandSherwin RolandSherwin changed the base branch from stable to main October 4, 2024 17:37
@RolandSherwin RolandSherwin changed the base branch from main to rc-2024.10.2 October 4, 2024 17:43
@jacderida jacderida merged commit 90dfd39 into maidsafe:rc-2024.10.2 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacderida jacderida jacderida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RolandSherwin @jacderida