feat(evmlib): Chunk->Data #2185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
reviewed
Oct 3, 2024
Comment on lines
266
to
270
| ## [0.14.35](https://github.com/maidsafe/safe_network/compare/sn_transfers-v0.14.34...sn_transfers-v0.14.35) - 2024-01-09 | ||
|
|
||
| ### Added | ||
| - *(client)* extra sleep between chunk verification | ||
| - *(client)* extra sleep between data verification | ||
|
|
There was a problem hiding this comment.
Not sure we should change this in the Changelog file too!!
There was a problem hiding this comment.
ups! FNR gone TOO FAR
mickvandijke
reviewed
Oct 3, 2024
evmlib/artifacts/DataPayments.json
Outdated
There was a problem hiding this comment.
I need to update the smart contract first to reflect these name changes in here.
Can this be left out in this PR? I'll open up a follow-up PR with the updated contract and new contract address.
There was a problem hiding this comment.
im not sure what parts need left out (but yeh, whatever makes sense)
There was a problem hiding this comment.
(is the contract not in here? I thought it was contained in the evm crate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.