Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #2153

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: fix typos #2153

merged 1 commit into from
Oct 3, 2024
+4 −4

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Sep 30, 2024

chore: fix typos

@maqi maqi enabled auto-merge October 3, 2024 10:35
maqi
maqi requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@maqi maqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @omahs ,

Thx for the PR and really good catches.
However, the commit title itself is failing the CI check.

Could you please :

  • squash two commits into one
  • change the commit title to be chore: fix typos

Thank you very much.

auto-merge was automatically disabled October 3, 2024 14:15

Head branch was pushed to by a user without write access

@omahs
Copy link
Contributor Author

omahs commented Oct 3, 2024

@maqi Hey, sure. Just squashed!

@maqi maqi enabled auto-merge October 3, 2024 16:56
@maqi maqi added this pull request to the merge queue Oct 3, 2024
Merged via the queue into maidsafe:main with commit d3ed939 Oct 3, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maqi maqi maqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omahs @maqi