deflateCopy(): Fix allocation and copying of pending_buf in LIT_MEM mode #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching that! Fixed. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 21, 2023
This applies the fix from madler/zlib#900 and adds a test. Bug: 1513368 Change-Id: I38025c66e1ef2420c726406ddefe6c728bdb6458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5139141 Commit-Queue: Adenilson Cavalcanti <[email protected]> Auto-Submit: Hans Wennborg <[email protected]> Reviewed-by: Adenilson Cavalcanti <[email protected]> Cr-Commit-Position: refs/heads/main@{#1239920}
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.zlib
that referenced
this pull request
Dec 21, 2023
This applies the fix from madler/zlib#900 and adds a test. Bug: 1513368 Change-Id: I38025c66e1ef2420c726406ddefe6c728bdb6458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5139141 Commit-Queue: Adenilson Cavalcanti <[email protected]> Auto-Submit: Hans Wennborg <[email protected]> Reviewed-by: Adenilson Cavalcanti <[email protected]> Cr-Commit-Position: refs/heads/main@{#1239920} NOKEYCHECK=True GitOrigin-RevId: 5672e5e75c159ba1742f8cfd784d294cff21c597
|
Merged commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed in internal testing that the state didn't get copied correctly (see https://crbug.com/1513368).