Ensure that the order in param_card.inc is reproducible in the madgraph4gpu repo #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent_card.dat _before_ `treatcards param` to prevent param_card.inc changes during rebuild This is related to oliviermattelaer/mg5amc_test#2
…card.dat in CODEGEN/generateAndCompare.sh: as expected, the order in param_card.inc has changed This is related to oliviermattelaer/mg5amc_test#2
… changes in (all?) .mad directories, as expected
oliviermattelaer
approved these changes
Sep 16, 2024
|
Thanks! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oliviermattelaer this should be a no brainer.
I need this to ensure reproducibilit when I run various tests. I noticed that Param_card.inc was sometimes changed during a rebuild. I understood where it comes from, fixed it and regenerated. This is the same issue as in oliviermattelaer/mg5amc_test#2, which has resurfaced after various changes in patchMad.sh etc.
This ONLY affects the generated code in the madgraph4gpu repo.
Can you please approve? Thanks
Andrea