Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for forms and controllers + event listeners #23

Open
wants to merge 17 commits into
base: develop-v3
Choose a base branch
from
Open

Add support for forms and controllers + event listeners #23

wants to merge 17 commits into from

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Feb 8, 2023 •
edited
Loading

First I just wanted to add support for forms (see #4).
While implementing this PR got bigger and bigger - maybe we could also split some parts
This PR is based on the v3-branch which also introduces some more breakpoints (#19).

In summary I did the following big changes

  • add translations
  • add dependency injection
  • refactor hooks + callbacks to event listeners
  • refactor content elements to controllers
  • add support for columns in form fields
  • add backend assets via event listener
  • add migrations for xlarge to keep the previous output

@rabauss
Copy link
Contributor Author

rabauss commented Mar 10, 2023

@ausi what about this PR?

@rabauss
Copy link
Contributor Author

rabauss commented May 10, 2023

I refactored some suggestions from the review - hopefully I did not miss anything.
There is no config for code style so I was not sure which one I could use!

@rabauss
Copy link
Contributor Author

rabauss commented Nov 6, 2023

@ausi Any suggestions to merge this PR?

@ausi
Copy link
Member

ausi commented Nov 6, 2023

Looks ready to merge on a first glance, will try to find some time, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabauss @ausi