Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: delete cpu.limits from the limitrange configuration #346

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Dec 19, 2023

PR Description

  • Deleted cpu.limits configuration on limitrange (namespace) level. It creates more problems than it helps
  • Updated the module documentation

Fixes #345

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested a review from a team December 19, 2023 10:59
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mglotov mglotov merged commit 79f8442 into main Dec 20, 2023
10 checks passed
@mglotov mglotov deleted the limitrange-config branch December 20, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not force cpu.limits using LimitRange configuration
3 participants