Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify URL path of DeleteGraphDef #158

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Modify URL path of DeleteGraphDef #158

merged 2 commits into from
Jun 4, 2024

Conversation

roodni
Copy link
Contributor

@roodni roodni commented Jun 3, 2024

Due to discussion in #157, the URL path for DeleteGraphDef (which is a recently created API) was changed from DELETE /api/v0/graph-defs/delete to DELETE /api/v0/graph-defs.

lufia
lufia approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@lufia lufia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether old /delete suffixed API should be kept until when. But to promote to upgrade from old version for our users as far as possible, we would be better to retract v0.33.0.

@roodni roodni merged commit 5094607 into master Jun 4, 2024
10 checks passed
@roodni roodni deleted the modify_DeleteGraphDef_api_url branch June 4, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lufia lufia lufia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roodni @lufia