Always add Content-Type header for non GET APIs
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur1
approved these changes
Nov 13, 2023
mackerel.go
Outdated
| @@ -174,7 +174,7 @@ func requestInternal[T any](client *Client, method, path string, params url.Valu | |||
| if err != nil { | |||
| return nil, nil, err | |||
| } | |||
| if body != nil { | |||
| if body != nil || method != "GET" { | |||
There was a problem hiding this comment.
To use http.MethodGet constant instead of "GET" will make the implementation more safety.
Comment on lines
+54
to
+62
| ts := httptest.NewServer(http.HandlerFunc(func(res http.ResponseWriter, req *http.Request) { | ||
| if !test.hasContentTypeHeader && req.Header.Get("Content-Type") == "application/json" { | ||
| t.Error("Content-Type header should not have application/json") | ||
| } | ||
| if test.hasContentTypeHeader && req.Header.Get("Content-Type") != "application/json" { | ||
| t.Error("Content-Type header should have application/json") | ||
| } | ||
| res.Write([]byte(`{"success": true}`)) // nolint | ||
| })) |
There was a problem hiding this comment.
How about a comment that this test server's behavior is similar to Mackerel's public API?
|
Oops, I didn't notice that Content-Type is required on sending empty body. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that non GET APIs must always have Content-Type: application/json request header even though they don't require request body.
For example,
But recent changes stop sending them and got errors like
error API request failed: Illegal Content-Type. Please try with "Content-Type: application/json".