Merge pull request #304 from ygurumi/check-log-err-concat

[check-log] Make building the error lines efficiently
mackerelio · Nov 7, 2019 · ab310e7 · ab310e7
2 parents 86ed8ec + d8e225d
commit ab310e7
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/check-log/lib/check-log.go b/check-log/lib/check-log.go
@@ -353,6 +353,7 @@ func (opts *logOpts) searchReader(ctx context.Context, rdr io.Reader) (warnNum,
 		newReader = newBufferedReader
 	}
 
+	var errLinesBuilder strings.Builder
 	r := newReader(rdr)
 	for ctx.Err() == nil {
 		lineBytes, rErr := r.ReadBytes('\n')
@@ -377,7 +378,8 @@ func (opts *logOpts) searchReader(ctx context.Context, rdr io.Reader) (warnNum,
 				if err != nil {
 					warnNum++
 					critNum++
-					errLines += line + "\n"
+					errLinesBuilder.WriteString(line)
+					errLinesBuilder.WriteString("\n")
 				} else {
 					levelOver := false
 					if level > opts.WarnLevel {
@@ -389,16 +391,20 @@ func (opts *logOpts) searchReader(ctx context.Context, rdr io.Reader) (warnNum,
 						critNum++
 					}
 					if levelOver {
-						errLines += line + "\n"
+						errLinesBuilder.WriteString(line)
+						errLinesBuilder.WriteString("\n")
 					}
 				}
 			} else {
 				warnNum++
 				critNum++
-				errLines += line + "\n"
+				errLinesBuilder.WriteString(line)
+				errLinesBuilder.WriteString("\n")
 			}
 		}
 	}
+
+	errLines = errLinesBuilder.String()
 	return
 }