Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudwatch-logs-aggregator] BREAKING CHANGE: Rollback breaking changes for is_enabled variable #25

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Arthur1
Copy link
Member

@Arthur1 Arthur1 commented Jan 24, 2024

v0.2.2 release contains a breaking change about is_enabled variable in spite of a patch version update. Since this change is undesirable considering the abstractness of the module, we made the following changes:

  • restore is_enabled (boolean) variable to specify whether the rule is enabled
    • If it is true/false, pass "ENABLED"/"DISABLED" for state of aws_cloudwatch_event_rule
  • remove state variable instead (BREAKING CHANGE for v0.2.2 users, but not so for users before one)

@Arthur1 Arthur1 self-assigned this Jan 24, 2024
@Arthur1 Arthur1 merged commit fe1cfc1 into main Jan 26, 2024
1 check passed
@Arthur1 Arthur1 deleted the is_enabled_comeback branch January 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants