Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make training step re-runnable #54

Closed
wants to merge 4 commits into from
Closed

Make training step re-runnable #54

wants to merge 4 commits into from

Conversation

arthurBarthe
Copy link
Collaborator

@arthurBarthe arthurBarthe commented Jun 20, 2023

This corrects for minor issues that were occurring when running the training step. It closes #33. Note that the bug in #42 does not seem to occur as long as the processed data is large enough.

@dorchard dorchard changed the title Training step Make training step reproducible Jun 27, 2023
@raehik raehik self-assigned this Jun 27, 2023
@raehik raehik self-requested a review June 27, 2023 14:48
@raehik raehik removed their assignment Jun 27, 2023
@raehik
Copy link
Collaborator

raehik commented Jun 27, 2023

Rebased from main: CI changes from #56 , some project meta changes from 630efad

@mondus
Copy link
Collaborator

mondus commented Jun 27, 2023

We want to get input from @CemGultekin1 on if our changes to mlflow commands are reasonable. We would like to ensure that this PR incorporates the changes that were made in the informal fork. The question is "Have we incorporated the same idea?", "Can our mlflow commands be improved". We certainly need to document better when the arguments are.

@dorchard

This comment was marked as off-topic.

@dorchard
Copy link
Collaborator

dorchard commented Jun 27, 2023

Another query: the example command line includes -P exp_id=<data_experiment_id> -P run_id=<data_run_id> How important is this and what guidance should the user be given about how to chose these? I found that they had to be filled in, but it looks like there is "free choice"?

@dorchard dorchard marked this pull request as draft June 27, 2023 17:10
@dorchard dorchard changed the title Make training step reproducible Make training step re-runnable Jul 4, 2023
@raehik raehik mentioned this pull request Jul 17, 2023
1 task
@raehik
Copy link
Collaborator

raehik commented Jul 21, 2023

#73 covers these changes -- closing.

@raehik raehik closed this Jul 21, 2023
@MarionBWeinzierl MarionBWeinzierl deleted the training_step branch September 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get training code to run
4 participants