Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused __init__.py #115

Merged
merged 1 commit into from
Dec 19, 2023
Merged

remove unused __init__.py #115

merged 1 commit into from
Dec 19, 2023

Conversation

raehik
Copy link
Collaborator

@raehik raehik commented Dec 13, 2023 •
edited
Loading

Two One __init__.py files which isn't useful.

@raehik raehik changed the title Remove init py remove unused __init__.pys Dec 13, 2023
@dorchard
Copy link
Collaborator

Yes looks reasonable as long as we don't want to use analysis as a package?

@raehik
remove analysis/__init__.py
e4b9926 
Empty, not required.
@raehik
Copy link
Collaborator Author

raehik commented Dec 19, 2023

now we just remove the analysis __init__.py, not the root one too

@dorchard dorchard self-requested a review December 19, 2023 16:12
@raehik raehik merged commit 3102f7b into main Dec 19, 2023
@raehik raehik changed the title remove unused __init__.pys remove unused __init__.py Dec 19, 2023
@raehik raehik deleted the remove-init-py branch December 19, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorchard dorchard dorchard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raehik @dorchard