Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of small changes based on my explorations #100

Closed
wants to merge 47 commits into from

Conversation

dorchard
Copy link
Collaborator

@dorchard dorchard commented Nov 8, 2023

I was trying to go towards updating test_global_control.ipynb but these errors/inconsistencies got in my way. I fixed them on the way. However, I haven't been able to circumvent the mlflow setup in this notebook yet.

Rewrite as a library (set of functions) and a CLI.
Cleaner subdomain configuration.
Also locks intake catalog to current HEAD.
No need to repeat sigma according to docs.
Also does more operations up front in the CLI for testing purposes.
* Hardcode subdomains instead of loading from hardcoded file on disk
  (less surprising).
* Clean up plotting code.
* Clarify dependencies.

Generated figure matches previous visually.
From examples/jupyter-notebooks/README.md .
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dorchard dorchard requested a review from raehik November 8, 2023 23:07
@raehik raehik force-pushed the data-step-refactor branch 2 times, most recently from 0c93ea2 to ebfcd52 Compare November 9, 2023 13:59
@raehik
Copy link
Collaborator

raehik commented Nov 9, 2023

rebased onto main over #102

@raehik raehik closed this Nov 9, 2023
@dorchard dorchard deleted the data-step-refactor-dom branch November 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants