Clippy/fmt #48
clippy
3 errors, 5 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 3 |
| Warning | 5 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.82.0-nightly (f8060d282 2024-07-30)
- cargo 1.82.0-nightly (b5d44db1d 2024-07-26)
- clippy 0.1.82 (f8060d2 2024-07-30)
Annotations
Check failure on line 241 in src/widget/dots.rs
github-actions / clippy
casting `usize` to `u16` may truncate the value
error: casting `usize` to `u16` may truncate the value
--> src/widget/dots.rs:241:38
|
241 | ... shell.publish((self.on_click)(i as u16));
| ^^^^^^^^
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
= note: `#[deny(clippy::cast_possible_truncation)]` implied by `#[deny(clippy::pedantic)]`
help: ... or use `try_from` and handle the error accordingly
|
241 | shell.publish((self.on_click)(u16::try_from(i)));
| ~~~~~~~~~~~~~~~~
Check failure on line 120 in src/view/overview.rs
github-actions / clippy
casting `u16` to `i16` may wrap around the value
error: casting `u16` to `i16` may wrap around the value
--> src/view/overview.rs:120:29
|
120 | character.base_size = (val as i16
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
= note: `#[deny(clippy::cast_possible_wrap)]` implied by `#[deny(clippy::pedantic)]`
Check failure on line 122 in src/view/overview.rs
github-actions / clippy
casting `i16` to `u16` may lose the sign of the value
error: casting `i16` to `u16` may lose the sign of the value
--> src/view/overview.rs:120:28
|
120 | character.base_size = (val as i16
| ___________________________________________^
121 | | - character.get_modifier(Trait::DerivedTrait(DerivedTrait::Size)))
122 | | as u16;
| |______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
note: the lint level is defined here
--> src/main.rs:2:9
|
2 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::cast_sign_loss)]` implied by `#[deny(clippy::pedantic)]`
Check warning on line 76 in src/i18n.rs
github-actions / clippy
usage of an `Arc` that is not `Send` and `Sync`
warning: usage of an `Arc` that is not `Send` and `Sync`
--> src/i18n.rs:76:3
|
76 | Arc::new(DefaultLocalizer::new(&*LANGUAGE_LOADER, &Localizations));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `Arc<DefaultLocalizer<'_>>` is not `Send` and `Sync` as `DefaultLocalizer<'_>` is neither `Send` nor `Sync`
= help: if the `Arc` will not used be across threads replace it with an `Rc`
= help: otherwise make `DefaultLocalizer<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
Check warning on line 100 in src/component/traits.rs
github-actions / clippy
this `if` has identical blocks
warning: this `if` has identical blocks
--> src/component/traits.rs:98:45
|
98 | let alternate_xp = if self.traits.alt_opt {
| ___________________________________________________^
99 | | row![]
100 | | } else {
| |_________^
|
note: same as this
--> src/component/traits.rs:100:10
|
100 | } else {
| ________________^
101 | | row![
102 | | // text(format!(
103 | | // "{}: {}",
... |
107 | | ]
108 | | };
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
= note: `#[warn(clippy::if_same_then_else)]` on by default
Check warning on line 16 in src/component/traits.rs
github-actions / clippy
fields `alternate_beats`, `alternate_experience`, and `splat` are never read
warning: fields `alternate_beats`, `alternate_experience`, and `splat` are never read
--> src/component/traits.rs:16:2
|
9 | struct Traits {
| ------ fields in this struct
...
16 | alternate_beats: u16,
| ^^^^^^^^^^^^^^^
17 | alternate_experience: u16,
| ^^^^^^^^^^^^^^^^^^^^
...
21 | splat: String,
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 74 in src/widget/track.rs
github-actions / clippy
unused variable: `renderer`
warning: unused variable: `renderer`
--> src/widget/track.rs:74:3
|
74 | renderer: &Renderer,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_renderer`
Check warning on line 73 in src/widget/track.rs
github-actions / clippy
unused variable: `tree`
warning: unused variable: `tree`
--> src/widget/track.rs:73:3
|
73 | tree: &mut widget::Tree,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_tree`
|
= note: `#[warn(unused_variables)]` on by default