Skip to content

Refactor components #49

Refactor components

Refactor components #49

Triggered via push July 31, 2024 18:33
Status Failure
Total duration 4m 22s
Artifacts

dev.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 14 warnings
casting `usize` to `u16` may truncate the value: src/widget/dots.rs#L241
error: casting `usize` to `u16` may truncate the value --> src/widget/dots.rs:241:38 | 241 | ... shell.publish((self.on_click)(i as u16)); | ^^^^^^^^ | = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation = note: `#[deny(clippy::cast_possible_truncation)]` implied by `#[deny(clippy::pedantic)]` help: ... or use `try_from` and handle the error accordingly | 241 | shell.publish((self.on_click)(u16::try_from(i))); | ~~~~~~~~~~~~~~~~
casting `u16` to `i16` may wrap around the value: src/component/traits.rs#L26
error: casting `u16` to `i16` may wrap around the value --> src/component/traits.rs:26:28 | 26 | character.base_size = (val as i16 | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap = note: `#[deny(clippy::cast_possible_wrap)]` implied by `#[deny(clippy::pedantic)]`
casting `i16` to `u16` may lose the sign of the value: src/component/traits.rs#L26
error: casting `i16` to `u16` may lose the sign of the value --> src/component/traits.rs:26:27 | 26 | character.base_size = (val as i16 | _______________________________________^ 27 | | - character.get_modifier(Trait::DerivedTrait(DerivedTrait::Size))) 28 | | as u16; | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss = note: `#[deny(clippy::cast_sign_loss)]` implied by `#[deny(clippy::pedantic)]`
this argument is passed by value, but not consumed in the function body: src/component/traits.rs#L21
error: this argument is passed by value, but not consumed in the function body --> src/component/traits.rs:21:36 | 21 | pub fn update(&mut self, message: Message, character: &mut Character) { | ^^^^^^^ help: consider taking a reference instead: `&Message` | help: consider marking this type as `Copy` --> src/component/traits.rs:14:1 | 14 | pub struct Message(u16, Trait); | ^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![deny(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::needless_pass_by_value)]` implied by `#[deny(clippy::pedantic)]`
check
Clippy had exited with the 101 exit code
test
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
usage of an `Arc` that is not `Send` and `Sync`: src/i18n.rs#L76
warning: usage of an `Arc` that is not `Send` and `Sync` --> src/i18n.rs:76:3 | 76 | Arc::new(DefaultLocalizer::new(&*LANGUAGE_LOADER, &Localizations)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `Arc<DefaultLocalizer<'_>>` is not `Send` and `Sync` as `DefaultLocalizer<'_>` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `DefaultLocalizer<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
unused import: `traits::DerivedTrait`: src/view/overview.rs#L13
warning: unused import: `traits::DerivedTrait` --> src/view/overview.rs:13:2 | 13 | traits::DerivedTrait, | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/