Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to language models in README #757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MJochim
Copy link

@MJochim MJochim commented Mar 25, 2024

The list of languages is no longer in transcribe.py, it’s been moved to alignment.py. I have created a new permalink.

I would suggest another change: remove

, and use the wihisper --model large

from line 141. It seems to work with --model small just as well. But I am not sure why it was there in the first place, so I haven’t included the change in this PR.

@deep-pipeline
Copy link

@m-bain this PR 757 from @MJochim seems to me to supercede PR #522 (which simply changes the README list of language codes.) and instead it directs people to look at the code for the HF related models.

That's probably a bit less repo-browser / user-friendly than updating a full language code list, but is may be more sustainable for README accuracy and developer helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants